Hello again!
This week, we had a look at the code metrics from codacy. As we already integrated codacy in our workflow, it makes sense to look at the change proposals so we also have a more stable and more secure application.
The following screenshots show you the issue dashboard as well as a detailed description of the Security and Error Prone issues:
Security Issues can possibly make our application vulnerable to malitious users and Error Prone issues could cause in the application not working properly.
The security issue says that it’s not good to bind an application to all interfaces (That’s what happens when you just say 0.0.0.0 and also don’t specify any protocol). But this is basically a non-issue as the crawler runs in a docker container and hence behind a reverse proxy that already filters and routes all the HTTP traffic. This is why we are not going to adress this issue.
Two of the Error Prone issues complain about our docker file. We fixed both of them as they ensure that every re-deployment of the crawler uses the right version of python and all the required files are copied correctly to the docker container.
The other two Error Prone issues complain about wrong CSS Syntax which actually isn’t the case, so we think there might be some problem with codacy or maybe we just use another version of CSS.
The following screenshot shows the dashboard after our fix:
Here you can find our Codacy Dashboard and our Fix-Commit.
We also had a look at the code complexity codacy told us, but as you can see in the following screenshot, the complexity is 0% for us, so no issues here:
This is one of our last blog posts, so thanks already for sticking around. We hope that you also follow along until our very last post.
Until then, have a great week.
Team Betterzon
Hello Team Betterzon,
we like your blog and following you with all steps of your project. You explained very well what you did and why you didn’t changed some issues… You also linked your commit so we can see your changes in the code.
Sure, we will look at your blog in the next weeks 🙂
See you soon,
TaskHUB
Hello Betterszon team we also agree with the colleagues from taskhub we are also big fans of your work and the text made it clear why you didn’t do some of the things you did.
it is nice to see that you have grown like a plant with the tasks you have done
green greetings
PlantsHub
Hello Betterzon,
like every week your post is seamless and fullfills all requirements.
We really like to read your posts beacause it gives us some ideas how to make the tasks ourselves.
Also your whole project is really promising and ists very nice to see what kind of progress you are making throughout the past time.
kr
memeVZ